3350 tool to automatically convert obsolete variables from input file #3397
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3397 +/- ##
==========================================
+ Coverage 27.71% 28.43% +0.71%
==========================================
Files 77 77
Lines 18084 19215 +1131
==========================================
+ Hits 5012 5463 +451
- Misses 13072 13752 +680 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| changes_made.append( | ||
| f"Commented out obsolete variable: {variable_name}" | ||
| ) | ||
| else: |
There was a problem hiding this comment.
What is the replacement is a list?
Having, for example, the variable thshield in the input file causes a TypeError: replace() argument 2 must be str, not list
There was a problem hiding this comment.
I hadn't considered that there were lists of replacements. Not sure there is an ideal solution there... I don't really like the idea of writing the new variables with "wrong" values (for ex: the original value of replaced variable). I could just write them without values but this will "break" input file. Maybe this is acceptable to force the user to intervene.
There was a problem hiding this comment.
Added error message for when there is a list of replacements.
process/main.py
Outdated
| continue | ||
|
|
||
| # Extract the variable name before the separator | ||
| variable_name = line.strip().split(" ", 1)[0] |
There was a problem hiding this comment.
Putting fdeut=0.6 or fdeut= 0.6 in the input file causes
Unknown variable in input file: fdeut
Error occurred at this line in the IN.DAT file: 449
fdeut=0.6
There was a problem hiding this comment.
I improved this to detect these situations.
…ment. Modified parsing to find variables with spacing around equals. Added error for when there is a list of replacements
I modified this validate_input function and added a CLI argument "replace_obsolete"
Now if you pass this argument when you run PROCESS it will automatically convert the variables, spit out the conversion in the terminal and write a comment in the input file where the name was changed.